Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-PSA-Crypto out of source build #9767

Merged
merged 2 commits into from
Jan 7, 2025
Merged

TF-PSA-Crypto out of source build #9767

merged 2 commits into from
Jan 7, 2025

Conversation

Harry-Ramsey
Copy link
Contributor

@Harry-Ramsey Harry-Ramsey commented Nov 11, 2024 •
edited
Loading

Description

Closes #9755

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog not required because: testing API changes.
  • development PR provided.
  • framework PR provided #77
  • TF-PSA-Crypto provided #121
  • 3.6 PR not required because: for repo split.
  • 2.28 PR not required because: for repo split.
  • tests not required.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@Harry-Ramsey Harry-Ramsey changed the title Tf psa crypto out of source development tf-psa-crypto out of source development Nov 11, 2024
@Harry-Ramsey Harry-Ramsey changed the title tf-psa-crypto out of source development tf-psa-crypto out of source build Nov 11, 2024
@Harry-Ramsey
Copy link
Contributor Author

Harry-Ramsey commented Nov 11, 2024 •
edited
Loading

This should pass all tests except test_tf_psa_crypto_cmake_as_package. I believe going forward all tf-psa-crypto components should include tf_psa_crypto in the name.

I have another branch where I attempted to use --list-all-components however the race conditions from forking due to bash substitutions were too chaotic to manage with some tests failing and other succeeding at will.

@Harry-Ramsey Harry-Ramsey self-assigned this Nov 11, 2024
@Harry-Ramsey Harry-Ramsey force-pushed the tf-psa-crypto-out-of-source-development branch from ba66691 to 9a0200c Compare November 12, 2024 12:26
@Harry-Ramsey Harry-Ramsey added enhancement needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d) labels Nov 12, 2024
@Harry-Ramsey Harry-Ramsey mentioned this pull request Nov 14, 2024
Closed
5 tasks
@Harry-Ramsey Harry-Ramsey force-pushed the tf-psa-crypto-out-of-source-development branch from 9a0200c to de49f62 Compare November 18, 2024 10:47
@Harry-Ramsey Harry-Ramsey mentioned this pull request Nov 18, 2024
Merged
@Harry-Ramsey Harry-Ramsey changed the title tf-psa-crypto out of source build TF-PSA-Crypto out of source build Nov 18, 2024
@Harry-Ramsey Harry-Ramsey added the needs-preceding-pr Requires another PR to be merged first label Nov 20, 2024
@Harry-Ramsey Harry-Ramsey force-pushed the tf-psa-crypto-out-of-source-development branch from de49f62 to 22a36f8 Compare November 20, 2024 15:07
@Harry-Ramsey Harry-Ramsey removed the needs-preceding-pr Requires another PR to be merged first label Nov 21, 2024
@Harry-Ramsey Harry-Ramsey force-pushed the tf-psa-crypto-out-of-source-development branch 11 times, most recently from eff1862 to f6d7939 Compare December 9, 2024 11:41
@ronald-cron-arm ronald-cron-arm self-requested a review December 12, 2024 14:15
@Harry-Ramsey Harry-Ramsey reopened this Dec 17, 2024
@Harry-Ramsey Harry-Ramsey force-pushed the tf-psa-crypto-out-of-source-development branch 2 times, most recently from 179f1f7 to 94f5051 Compare December 24, 2024 12:32
@Harry-Ramsey Harry-Ramsey force-pushed the tf-psa-crypto-out-of-source-development branch from 94f5051 to 4eae5f7 Compare December 24, 2024 14:33
@mpg mpg self-requested a review January 6, 2025 10:08
@Harry-Ramsey Harry-Ramsey force-pushed the tf-psa-crypto-out-of-source-development branch 2 times, most recently from 818f333 to 273dd58 Compare January 6, 2025 10:57
ronald-cron-arm
ronald-cron-arm previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpg mpg removed the needs-reviewer This PR needs someone to pick it up for review label Jan 7, 2025
@ronald-cron-arm ronald-cron-arm mentioned this pull request Jan 7, 2025
Closed
@Harry-Ramsey
Update framework submodule for CMake TF-PSA-Crypto
34a0b6d 
This commit updates the framework submodule to include commits relevant
to running TF-PSA-Crypto using CMake build system.

Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
@Harry-Ramsey
Update TF-PSA-Crypto for out of source builds
1e8992b 
This commit updates TF-PSA-Crypto to enable out of source builds by
default.

Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
@Harry-Ramsey Harry-Ramsey force-pushed the tf-psa-crypto-out-of-source-development branch from 273dd58 to 1e8992b Compare January 7, 2025 11:44
ronald-cron-arm
ronald-cron-arm approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpg mpg added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Jan 7, 2025
@mpg mpg enabled auto-merge January 7, 2025 12:00
@mpg mpg added this pull request to the merge queue Jan 7, 2025
Merged via the queue into Mbed-TLS:development with commit 69a2182 Jan 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronald-cron-arm ronald-cron-arm ronald-cron-arm approved these changes

@mpg mpg mpg approved these changes

Assignees

@Harry-Ramsey Harry-Ramsey

Labels
approved Design and code approved - may be waiting for CI or backports enhancement priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Roadmap pull requests (new board)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tf-psa-crypto all.sh: make the core manage the build directory
3 participants
@Harry-Ramsey @mpg @ronald-cron-arm