Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move back test configs #9787

Merged

Conversation

ronald-cron-arm
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm commented Nov 20, 2024

Description

Companion PR of #9771

PR checklist

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm ronald-cron-arm added enhancement needs-ci Needs to pass CI tests priority-high High priority - will be reviewed soon labels Nov 20, 2024
@ronald-cron-arm ronald-cron-arm added needs-review Every commit must be reviewed by at least two team members, and removed needs-ci Needs to pass CI tests labels Nov 20, 2024
@ronald-cron-arm
Copy link
Contributor Author

On OpenCI only a glitch in an DTLS test thus the CI can be considered green.

Copy link
Contributor

@Harry-Ramsey Harry-Ramsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,46 @@
/*
* Mbed TLS configuration for PSA test driver libraries. It includes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that moving forward there will be two versions of the test driver?

  • tests/configs/config_test_driver.h for 3.6
  • tf-psa-crypto/tests/configs/config_test_driver.h for devel, and 4.0 onwards?

Would it be good to add a comment to link those, so when someone is adding a feature they will know about it to backport it here?

@ronald-cron-arm ronald-cron-arm merged commit c5197ad into Mbed-TLS:mbedtls-3.6 Nov 21, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs-review Every commit must be reviewed by at least two team members, priority-high High priority - will be reviewed soon
Development

Successfully merging this pull request may close these issues.

3 participants