Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 3.6: Fix discussions of MBEDTLS_USE_PSA_CRYPTO in standalone documentation #9823

Open
wants to merge 2 commits into
base: mbedtls-3.6
Choose a base branch
from
Open

Backport 3.6: Fix discussions of MBEDTLS_USE_PSA_CRYPTO in standalone documentation #9823

wants to merge 2 commits into from
+7 −3

Conversation

gilles-peskine-arm
Copy link
Contributor

Minor corrections found while rewiewing #9818.

PR checklist

@gilles-peskine-arm
FFDH in TLS: it's only a limitation for TLS 1.2, not TLS 1.3
d78d695 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm
Distinguish between MBEDTLS_PSA_CRYPTO_C and MBEDTLS_PSA_CRYPTO_CLIENT
4f65e1f 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Dec 4, 2024
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Dec 4, 2024
Open
5 tasks
yanesca
yanesca approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanesca
Copy link
Contributor

yanesca commented Dec 19, 2024

The CI has passed, GitHub just didn't pick up on it: https://mbedtls.trustedfirmware.org/blue/organizations/jenkins/mbed-tls-pr-head/detail/PR-9823-head/1/pipeline

@yanesca yanesca removed the needs-review Every commit must be reviewed by at least two team members, label Dec 19, 2024
waleed-elmelegy-arm
waleed-elmelegy-arm approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@waleed-elmelegy-arm waleed-elmelegy-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@waleed-elmelegy-arm waleed-elmelegy-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-reviewer This PR needs someone to pick it up for review labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waleed-elmelegy-arm waleed-elmelegy-arm waleed-elmelegy-arm approved these changes

@yanesca yanesca yanesca approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Projects
Roadmap pull requests (new board)
Status: Has Approval
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilles-peskine-arm @yanesca @waleed-elmelegy-arm