Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch generate_psa_test.py to automatic dependencies for negative test cases #9909

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Switch generate_psa_test.py to automatic dependencies for negative test cases #9909

merged 4 commits into from
Jan 21, 2025

Conversation

gilles-peskine-arm
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm commented Jan 15, 2025 •
edited
Loading

This completes the forward port of #9025. Everything is happening in the submodules, except for removing the exceptions to test coverage that this is fixing.

PR checklist

@gilles-peskine-arm gilles-peskine-arm added component-crypto Crypto primitives and low-level interfaces needs-ci Needs to pass CI tests needs-preceding-pr Requires another PR to be merged first priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Jan 15, 2025
This was referenced Jan 15, 2025
Merged
Merged
@gilles-peskine-arm gilles-peskine-arm force-pushed the psa-storage-test-cases-never-supported-negative-dev branch 3 times, most recently from cd14308 to 87c49c3 Compare January 16, 2025 18:59
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Jan 16, 2025
Merged
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Jan 17, 2025
waleed-elmelegy-arm
waleed-elmelegy-arm previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@waleed-elmelegy-arm waleed-elmelegy-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

davidhorstmann-arm
davidhorstmann-arm previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gilles-peskine-arm
Update submodules
08c4362 
Catch up with Mbed-TLS/mbedtls-framework#104 =
"Switch generate_psa_test.py to automatic dependencies for negative test cases"

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm
Remove test coverage exceptions that are no longer needed
fe683e7 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm
Add ignore list entries for ECDH/FFDH algorithm without key type
13c418d 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm force-pushed the psa-storage-test-cases-never-supported-negative-dev branch from 87c49c3 to 13c418d Compare January 20, 2025 15:01
@gilles-peskine-arm
Copy link
Contributor Author

I rebased on top of development with the framework updated to the merge of Mbed-TLS/mbedtls-framework#104 and with crypto updated to the head of Mbed-TLS/TF-PSA-Crypto#157, to run the desired CI for Mbed-TLS/TF-PSA-Crypto#157.

This will need one more rewrite of the submodule-updating commit after Mbed-TLS/TF-PSA-Crypto#157 is merged.

@gilles-peskine-arm gilles-peskine-arm added needs-ci Needs to pass CI tests and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jan 20, 2025
davidhorstmann-arm
davidhorstmann-arm previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm
Update submodule
7dc5709 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm
Copy link
Contributor Author

And here's the last submodule update, with Mbed-TLS/TF-PSA-Crypto#157 merged.

@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, and removed needs-ci Needs to pass CI tests needs-preceding-pr Requires another PR to be merged first labels Jan 20, 2025
@waleed-elmelegy-arm waleed-elmelegy-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Jan 21, 2025
davidhorstmann-arm
davidhorstmann-arm approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@davidhorstmann-arm davidhorstmann-arm added this pull request to the merge queue Jan 21, 2025
Merged via the queue into Mbed-TLS:development with commit 5a77c23 Jan 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waleed-elmelegy-arm waleed-elmelegy-arm waleed-elmelegy-arm approved these changes

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Projects
Roadmap Board for Mbed TLS
Status: Done
Roadmap pull requests (new board)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilles-peskine-arm @davidhorstmann-arm @waleed-elmelegy-arm