New registration notification is not marked as read

[melroy89]

Describe the bug

When a new user is register, a new notification will now pop-up for admins to approve or reject.

On which Mbin instance did you find the bug?
kbin.melroy.org

Which Mbin version was running on the instance?
main

To Reproduce
Steps to reproduce the behavior:

1. Go to Notifications
2. See the registration notification

Expected behavior

A link to the approval registration page. (incl the correct page number), which is required when you the "New users have to be approved by an admin before they can log in." feature is checked.

The username link will never work when admin approval is required. Only show a link to the user if the admin approval feature is disabled.

Screenshots

[BentiGorlich]

Again this is only true when approvals are enabled in the admin settings. When approvals are not needed the link is working fine :D

[melroy89]

I edited my desc.

[melroy89]

Fixed in #1411? Right?

[melroy89]

Well except for "Only show a link to the user if the admin approval feature is disabled."

[BentiGorlich]

Hmm... Do you think we should remove the user_inline component? I mean maybe we could change the page it links to to the same signup request?

[melroy89]

Yes you can either disable the link (remove the link part) I guess. Or also point to the approval page.
Only when admin approval is enabled.

[melroy89]

@BentiGorlich Can we also "mark as read" the notification when clicking on the 'Open signup request' link?

[melroy89]

Notification doesn't get marked as read after clicking on the Open signup request link. Hence I reopen the ticket.

[melroy89]

I suspect an issue here somewhere:

mbin/src/Controller/User/UserFrontController.php

Line 58 in ff07ef7

$this->notificationRepository->markUserSignupNotificationsAsRead($loggedInUser, $user);

I think it's not sufficient to have this check only in the UserFrontController. Also the $this->getUser(); was already called on line 46:

mbin/src/Controller/User/UserFrontController.php

Line 46 in ff07ef7

$requestedByUser = $this->getUser();

I would like to at least add markUserSignupNotificationsAsRead to the AdminSignupRequestsController.php file.

[BentiGorlich]

Can we also "mark as read" the notification when clicking on the 'Open signup request' link?

I actually thought that I did that...

[melroy89]

Can we also "mark as read" the notification when clicking on the 'Open signup request' link?

I actually thought that I did that...

Well.. not really, there is only this mark as read at another location:

mbin/src/Controller/User/UserFrontController.php

Line 58 in ff07ef7

$this->notificationRepository->markUserSignupNotificationsAsRead($loggedInUser, $user);

However, this PR will fix all this: #1437