Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark signup notification as read, after clicking on the link #1437

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Mark signup notification as read, after clicking on the link #1437

merged 5 commits into from
Feb 7, 2025

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Feb 6, 2025

  • Mark the new signup notificaction "as read" after the admin clicked on the "Open signup request" link (just like we have with other notifications like the report notification, which is using the markReportNotificationsAsRead in the AdminReportController.php for example)

Fixes: #1408

@melroy89 melroy89 added bug Something isn't working enhancement New feature or request labels Feb 6, 2025
@melroy89 melroy89 requested a review from BentiGorlich February 6, 2025 19:42
@melroy89 melroy89 added this to the v1.8.0 milestone Feb 6, 2025
@melroy89 melroy89 requested a review from BentiGorlich February 6, 2025 20:35
@melroy89 melroy89 enabled auto-merge (squash) February 6, 2025 20:47
@melroy89 melroy89 mentioned this pull request Feb 6, 2025
Closed
@melroy89 melroy89 merged commit eebe806 into main Feb 7, 2025
7 checks passed
@melroy89 melroy89 deleted the mark_signup_user_notification_as_read branch February 7, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BentiGorlich BentiGorlich BentiGorlich approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

New registration notification is not marked as read
2 participants
@melroy89 @BentiGorlich