add default null to Instance entity nullables field #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BentiGorlich
approved these changes
Aug 8, 2024
ghost
approved these changes
Aug 8, 2024
add default values of null to DB nullable properties to prevent
access before initialization problems on php side
currently observed the error with the field
`Instance::$lastSuccessfulReceive` but added null default to all
nullable fields just in case
"Handling "App\Message\ActivityPub\Inbox\ActivityMessage" failed:
Typed property App\Entity\Instance::$lastSuccessfulReceive must not
be accessed before initialization"
asdfzdfj
force-pushed
the
fix/instance-entity-uninit-field
branch
from
a68e8e6 to
04e1939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add default values of null to DB nullable properties in
Instanceentity to prevent access before initialization problems on php sidecurrently observed the error with the field
Instance::$lastSuccessfulReceivebut added null default to all nullable fields just in case