Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search #1167

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Improve search #1167

merged 7 commits into from
Oct 16, 2024

Conversation

BentiGorlich
Copy link
Member

@BentiGorlich BentiGorlich commented Oct 6, 2024

  • only search a specific magazine
  • only search posts from a specific user
  • only search a specific type: threads, microblogs or both

UI changes

Old New
search Bildschirmfoto vom 2024-10-06 17-21-26 grafik
mobile grafik grafik
magazine search grafik grafik

Closes #1148, closes #844

@BentiGorlich BentiGorlich added the enhancement New feature or request label Oct 6, 2024
@BentiGorlich BentiGorlich added this to the v1.8.0 milestone Oct 6, 2024
@BentiGorlich BentiGorlich self-assigned this Oct 6, 2024
@jwr1
Copy link
Member

jwr1 commented Oct 6, 2024

Could this be added to the API as well, if that wasn't already planned?

@BentiGorlich
Copy link
Member Author

I need a PR template that asks whether you have thought about thw API 😂😂😂

@BentiGorlich
Copy link
Member Author

I will add it to this PR when I work on it the next time

@melroy89
Copy link
Member

melroy89 commented Oct 6, 2024

Change the branch. This is the main branch.

@BentiGorlich
Copy link
Member Author

Change the branch. This is the main branch.

I will, but boy this tone is not the right one...

@BentiGorlich BentiGorlich changed the base branch from main to dev/new_features October 6, 2024 16:51
@melroy89
Copy link
Member

melroy89 commented Oct 6, 2024

Change the branch. This is the main branch.

I will, but boy this tone is not the right one...

I'm not at home. I was just responding quickly.

- only search a specific magazine
- only search posts from a specific user
- only search a specific type: threads, microblogs or both
@BentiGorlich BentiGorlich force-pushed the new/search-improvements branch from b69ef85 to cc590cc Compare October 10, 2024 15:15
@melroy89
Copy link
Member

Now we also need to remove this security check from the dev/* branch pattern settings.

@BentiGorlich
Copy link
Member Author

Could it not also run here?

@melroy89
Copy link
Member

What do you mean? The audit-check replaces it. You can remove the security-check from the mandatory checks in the dev branch protection settings.

- in the search API add the new parameters
- improve the user retrieve API to search for users
@BentiGorlich BentiGorlich requested review from melroy89 and jwr1 October 10, 2024 16:27
@melroy89
Copy link
Member

Never mind about my previous comment (deleted), only integrate the button with the input field that would be cool enough.

Like this:

image

@melroyvandenberg
Copy link

melroyvandenberg commented Oct 11, 2024

Also "Both" isn't saying much if people didn't look at the drop-down options. You want to make it explicit here, like "Threads + Microblogs":

image

Otherwise at first glace you don't know what you are looking at: "both .. what?.."

@BentiGorlich
Copy link
Member Author

Change the branch. This is the main branch.

I will, but boy this tone is not the right one...

I'm not at home. I was just responding quickly.

Maybe "all types"?

@melroy89
Copy link
Member

Even then people don't know what you mean with 'type'? What kind of type? What type?

@BentiGorlich
Copy link
Member Author

I changed it to your suggestion :)

@BentiGorlich BentiGorlich merged commit 55cc85a into dev/new_features Oct 16, 2024
5 checks passed
@BentiGorlich BentiGorlich deleted the new/search-improvements branch October 16, 2024 11:11
BentiGorlich added a commit that referenced this pull request Nov 19, 2024
BentiGorlich added a commit that referenced this pull request Nov 24, 2024
@BentiGorlich BentiGorlich mentioned this pull request Nov 24, 2024
BentiGorlich added a commit that referenced this pull request Dec 8, 2024
BentiGorlich added a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Improvements Search filters
4 participants