[Feature] Admin approval #1232
Merged
[Feature] Admin approval #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BentiGorlich
added
enhancement
BentiGorlich
force-pushed
the
new/users-admin-approval
branch
from
0440e1f to
230d2d3
Compare
BentiGorlich
force-pushed
the
dev/new_features
branch
from
cf72318 to
7cd555b
Compare
BentiGorlich
force-pushed
the
new/users-admin-approval
branch
from
230d2d3 to
e644d0d
Compare
|
Nice! |
|
Do we have someone that is good in phrasing user facing stuff like the emails? @jwr1 or @TheVillageGuy maybe? |
melroy89
reviewed
Nov 20, 2024
melroy89
reviewed
Nov 20, 2024
melroy89
reviewed
Nov 20, 2024
melroy89
reviewed
Nov 20, 2024
|
The "One last step" in the message now contradict each other 😆 . Yes you still need to use the activation link, but if admin approval is required, this isn't the last step.. you than still need to wait. |
Yeah I know 😅, but I didn't know how to solve this. I didn't really want to mess up the existing translations... But if you think that it is necessary I will split the existing one up, so that both messages can be merged |
BentiGorlich
force-pushed
the
dev/new_features
branch
from
ed923ae to
9b44612
Compare
- admins can now decide to turn a mandatory approval on in the admin settings - a new tab will appear labelled "Applications" where new users that are not yet approved will appear - when the setting is enabled a new input will be displayed on the register page: "Application Text" - This behaviour will be apparent on registering with an added flash message informing the user about it - Users will receive an email when they are accepted or rejected - when a user is not approved they cannot log in and an appropriate message will be displayed - the register site now redirects to the login page instead of the front page
BentiGorlich
force-pushed
the
new/users-admin-approval
branch
from
8ed5d6a to
4868912
Compare
- Move from `isApproved` and `isRejected` to an enum model - update twig to v3.15 to use the new `enum` method - improve the signup_requests page - fix the `SettingsManager` handling of the new variable - fix the `UserCommand` not taking an application text
|
@melroy89 are you fine with the 2 flash messages upon signup? I think it is fine this way, but I can invest the work to fix it if you want to |
It's fine for me. |
melroy89
approved these changes
Nov 24, 2024
BentiGorlich
added a commit
that referenced
this pull request
Dec 8, 2024
Co-authored-by: TheVillageGuy <47496248+TheVillageGuy@users.noreply.github.com>
BentiGorlich
added a commit
that referenced
this pull request
Dec 10, 2024
Co-authored-by: TheVillageGuy <47496248+TheVillageGuy@users.noreply.github.com>
BentiGorlich
added a commit
that referenced
this pull request
Jan 7, 2025
Co-authored-by: TheVillageGuy <47496248+TheVillageGuy@users.noreply.github.com>
BentiGorlich
added a commit
that referenced
this pull request
Jan 7, 2025
Co-authored-by: TheVillageGuy <47496248+TheVillageGuy@users.noreply.github.com>
BentiGorlich
added a commit
that referenced
this pull request
Jan 7, 2025
Co-authored-by: TheVillageGuy <47496248+TheVillageGuy@users.noreply.github.com>
BentiGorlich
added a commit
that referenced
this pull request
Jan 7, 2025
Co-authored-by: TheVillageGuy <47496248+TheVillageGuy@users.noreply.github.com>
BentiGorlich
added a commit
that referenced
this pull request
Jan 13, 2025
Co-authored-by: TheVillageGuy <47496248+TheVillageGuy@users.noreply.github.com>
BentiGorlich
added a commit
that referenced
this pull request
Jan 14, 2025
Co-authored-by: TheVillageGuy <47496248+TheVillageGuy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
Pictures
Register Page
Admin application view
Mails
Closing #722