Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't federate anything from the random magazine #1236

Merged
merged 5 commits into from
Nov 24, 2024

Conversation

BentiGorlich
Copy link
Member

  • don't return the random magazine on webfinger requests
  • don't federate anything outwards from the random magazine

Closes #444

- don't return the random magazine on webfinger requests
- don't federate anything outwards from the random magazine
@BentiGorlich BentiGorlich added bug Something isn't working activitypub ActivityPub related issues backend Backend related issues and pull requests labels Nov 22, 2024
@BentiGorlich BentiGorlich self-assigned this Nov 22, 2024
@melroy89 melroy89 added this to the v1.7.3 milestone Nov 22, 2024
@melroy89
Copy link
Member

melroy89 commented Nov 22, 2024

OK I think I agree maybe, but..

What if I go to a random thread like: https://kbin.melroy.org/m/random/t/64276/Lovecraft-s-Cthulhu-Mythos-Reading-Order#comments

And I place a comment.. Will that still just work? I think the users of my instance who comment there would like to get their comment federated out. At least I would.

@BentiGorlich
Copy link
Member Author

yeah you're absolutely right. The author should still get the comments from us even if the thread is jn the random magazine... Gotta adjust the PR, pribably a lot...

@BentiGorlich BentiGorlich marked this pull request as draft November 22, 2024 16:35
@melroy89 melroy89 modified the milestones: v1.7.3, v1.7.4 Nov 23, 2024
Create-, Delete- and LikeHandler will federate things from the random magazine again, but only to the user audience and ignoring the random mag audience (which should also just not exist).
This should still allow people to interact with the microblog side of the fediverse
@BentiGorlich BentiGorlich marked this pull request as ready for review November 24, 2024 11:47
@melroy89
Copy link
Member

Let me try to run this on my instance. Just to check.

@BentiGorlich
Copy link
Member Author

Sounds like a good idea

@melroy89
Copy link
Member

Sounds like a good idea

Seems to work? https://wehavecookies.social/@BentiGorlich/113538159661153615

@melroy89
Copy link
Member

Can you reply one more time? I'm now for sure running the branch. Before it could have been still running on main.

@BentiGorlich
Copy link
Member Author

The important part is you replying to me. Inbound federation was not changed :)

@melroy89
Copy link
Member

melroy89 commented Nov 24, 2024

The important part is you replying to me. Inbound federation was not changed :)

I tried to reply again: https://kbin.melroy.org/m/random/p/186322/at-melroy-at-kbin-melroy-org-Here-is-a-test-toot-from-mastodon-for-you

Seems to work still: https://wehavecookies.social/@BentiGorlich/113538159661153615

@melroy89
Copy link
Member

What about comments under threads??

@BentiGorlich
Copy link
Member Author

Threads use the same CreateHandler so should also work fine

@melroy89
Copy link
Member

Yup that also works: https://kbin.melroy.org/m/random/t/295162/Crane-on-a-plant and https://lemmy.world/post/16073167

@melroy89
Copy link
Member

@BentiGorlich
Copy link
Member Author

And the likes are also working :)

@BentiGorlich BentiGorlich merged commit af60baa into main Nov 24, 2024
7 checks passed
@BentiGorlich BentiGorlich deleted the fix/random-federation branch November 24, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activitypub ActivityPub related issues backend Backend related issues and pull requests bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop federating /m/random
2 participants