Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search experience when searching for AP urls #1244

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

BentiGorlich
Copy link
Member

  • the search is now synchronous when searching for AP ids. That means when I want to look up a post that is not present on my instance it will not be dispatched to the background-workers, but instead be directly fetched and processed, so the user can see the post immediately
  • the search controller now takes into account that the URLs a users searches for are not necessarily the same as the id of the searched post, previously the result would just be empty. For example mastodon has different URLs when the user is looking at a post, vs the id this post returns:

Fixes #1195

- the search is now synchronous when searching for AP ids. That means when I want to look up a post that is not present on my instance it will not be dispatched to the background-workers, but instead be directly fetched and processed, so the user can see the post immediately
- the search controller now takes into account that the URLs a users searches for are not necessarily the same as the id of the searched post. For example mastodon has different URLs when the user is looking at a post, vs the id this post returns
@BentiGorlich BentiGorlich added enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end labels Nov 24, 2024
@BentiGorlich BentiGorlich added this to the v1.7.4 milestone Nov 24, 2024
@BentiGorlich BentiGorlich self-assigned this Nov 24, 2024
@melroy89
Copy link
Member

This is huge! Thanks 🎂

@BentiGorlich BentiGorlich enabled auto-merge (squash) November 25, 2024 11:27
@BentiGorlich BentiGorlich merged commit 834e802 into main Nov 25, 2024
7 checks passed
@BentiGorlich BentiGorlich deleted the fix/search-experience branch November 25, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the UX of searching for a URL
2 participants