Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new html to markdown converter for strikethrough support #1275

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

BentiGorlich
Copy link
Member

Strikethroughs are now properly converted to markdown:
grafik

Related PR for the future: thephpleague/html-to-markdown#257
Closes #1189

@BentiGorlich BentiGorlich added enhancement New feature or request backend Backend related issues and pull requests labels Dec 9, 2024
@BentiGorlich BentiGorlich added this to the v1.7.4 milestone Dec 9, 2024
@BentiGorlich BentiGorlich self-assigned this Dec 9, 2024
@melroy89
Copy link
Member

While we at here, shouldn't we also try to use BlockquoteConverter or something else?

@BentiGorlich BentiGorlich enabled auto-merge (squash) December 10, 2024 15:22
@BentiGorlich
Copy link
Member Author

As far as I could tell you don't need to add any of their converters manually other than the table one. All the others are enabled by default

@BentiGorlich BentiGorlich merged commit a007680 into main Dec 10, 2024
7 checks passed
@BentiGorlich BentiGorlich deleted the new/html2md-strikethrough branch December 10, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strikethrough missing from federated Mastodon post
2 participants