Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include last receive in the formula for dead instances #1277

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

BentiGorlich
Copy link
Member

An instance now counts as dead only if last successful deliver AND last successful receive are older than a week and there were 10 failed delivers in a row

This is of course open for discussion, but imo we have to include the receive in the formula. I looked at my instances and at fedia and there were just far too many instances that don't belong there

An instance now counts as dead only if last successful deliver AND last successful receive are older than a week and there were 10 failed delivers in a row
@BentiGorlich BentiGorlich added activitypub ActivityPub related issues backend Backend related issues and pull requests labels Dec 9, 2024
@BentiGorlich BentiGorlich added this to the v1.7.4 milestone Dec 9, 2024
@BentiGorlich BentiGorlich self-assigned this Dec 9, 2024
@melroy89
Copy link
Member

I assume lastSuccessfulReceive has an index, so the DB query performance is not impacted that much.

@BentiGorlich
Copy link
Member Author

I actually think that there is no index on the instance table other than the domain column

@BentiGorlich BentiGorlich enabled auto-merge (squash) December 10, 2024 15:20
@BentiGorlich BentiGorlich merged commit 8cbb51c into main Dec 10, 2024
7 checks passed
@BentiGorlich BentiGorlich deleted the new/instance-dead-receive-revive branch December 10, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activitypub ActivityPub related issues backend Backend related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants