Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data action kbin -> mbin rename #1278

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Dec 9, 2024

  • I renamed kbin_controller.js to mbin_controller.js, however then you apparently ALSO need to update the data-controller as well with this name. So Stimulus would load the controller.
  • Then I also did the rename on the data-action to mbin# (which is required after you renamed the data-controller).
  • In the swagger template (by NelmioApiDocBundle), we don't even use this navigation menu. This should be removed, because this is dead-code there.
    • While I was at here, I also improved the CSS in the Swagger template, so the logo actually is better displayed now within the SwaggerUI template.
  • Also update kbin_lang to mbin_lang while I found it anyways how it works now.
  • ALso rename kbin-container to mbin-container, while I'm here now.

Regression of: #1256

@melroy89 melroy89 added bug Something isn't working enhancement New feature or request labels Dec 9, 2024
@melroy89 melroy89 added this to the v1.7.4 milestone Dec 9, 2024
TheVillageGuy
TheVillageGuy previously approved these changes Dec 9, 2024
@melroy89 melroy89 merged commit 5ec3e71 into main Dec 9, 2024
7 checks passed
@melroy89 melroy89 deleted the fix_template_kbin_to_mbin_rename branch December 9, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants