Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aria attributes to cake day elements #841

Merged
merged 2 commits into from
Jun 19, 2024
Merged

add aria attributes to cake day elements #841

merged 2 commits into from
Jun 19, 2024

Conversation

e-five256
Copy link
Member

adds aria-hidden and aria-label attributes to the new cake day locations

  • cake icon on user page sidebar is decorative, as the label is already in the row, so gains aria-hidden=true
  • cake icon on user popover is meant to denote that's is the user's cake day, so gains an aria-label=Cake day element surrounding it
  • switched the padding to match how it is for other divs icons (if you compare with say follower count). we seem to use padding right .5rem on div i and then margin-left .5rem on btn spans (like the icons in the purge buttons)... I wonder if we should unite these, or it doesn't really matter
before after
image image
image image

@e-five256 e-five256 added the accessibility Accessibility related issues and pull requests label Jun 19, 2024
@e-five256 e-five256 merged commit 032c917 into main Jun 19, 2024
7 checks passed
@e-five256 e-five256 deleted the e5/cake-aria branch June 19, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Accessibility related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants