Fix rule mismatch on related entry front vs single #859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Entries were showing as being related for unrelated posts on the full entry listing views. If you navigated into the entry, it would show different or no related entries, because the rules between the two pages was different.
This makes the rules for what is considered a related entry consistent between the
EntryFrontController
andEntrySingleController
Rules from single view
mbin/src/Repository/EntryRepository.php
Line 445 in 2166fe8
Whether these are the actual rules we want to go with might be a separate discussion, this merely makes them consistent.
The before and after is a bit weird, because it might look worse, but keep in mind that these are unrelated posts (according to the
findCross
ruleset) being shown as related. The 2nd set of images shows how opening one of those posts in the before where it said there were related entries shows none.