Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rule mismatch on related entry front vs single #859

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

e-five256
Copy link
Member

@e-five256 e-five256 commented Jun 23, 2024

Issue: Entries were showing as being related for unrelated posts on the full entry listing views. If you navigated into the entry, it would show different or no related entries, because the rules between the two pages was different.

This makes the rules for what is considered a related entry consistent between the EntryFrontController and EntrySingleController

Rules from single view

if (\strlen($entry->title) <= 10 && !$entry->url) {

  • EntrySingleController
    • Has the same URL
    • Has the same title and title is over 10 characters
  • EntryFrontController
    • Has the same URL
    • Has the same title
      • change: and title is over 10 characters

Whether these are the actual rules we want to go with might be a separate discussion, this merely makes them consistent.

The before and after is a bit weird, because it might look worse, but keep in mind that these are unrelated posts (according to the findCross ruleset) being shown as related. The 2nd set of images shows how opening one of those posts in the before where it said there were related entries shows none.

before after
image image
image image
related entries from before still match
image
image

@e-five256 e-five256 added the bug Something isn't working label Jun 23, 2024
@e-five256 e-five256 merged commit e5963da into main Jun 25, 2024
7 checks passed
@e-five256 e-five256 deleted the e5/fix-crosspost-entryfront branch June 25, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants