When receiving an "Update" activity check permissions #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BentiGorlich
added
bug
|
This is a draft right now, because I did not live-test this yet, only wrote the code. That looks good to me right now, but I still gotta test it |
|
Everything works as expected |
ghost
approved these changes
Jul 25, 2024
BentiGorlich
added a commit
that referenced
this pull request
Aug 7, 2024
I noticed that editing an entry was not really working sometimes, the reason being (after testing locally) that it tries to parse a url from the users and magazines apId. This is not working, as the ap id looks like this: `normaluser@mbin.instance.tld` That is not a url, so yeah that cannot work. Since this has been used to check whether a user is from the same instance as the content they try to edit, this check is failing. So right now only remote moderators can edit their content Fixes Regression from #893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we do not check any permissions when receiving an "Update" (=edit) activity.
That means at the moment any user can send an "Update" activity to any post and mbin would just apply that update, regardless of whether the user should be able to do so as long as the HTTP headers are valid.
This PR implements a permission like this: a user should be able to modify a post if: