Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the LogicException when a report was rejected #915

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Fix the LogicException when a report was rejected #915

merged 4 commits into from
Jul 19, 2024

Conversation

BentiGorlich
Copy link
Member

Closes #584

@BentiGorlich BentiGorlich added bug Something isn't working backend Backend related issues and pull requests labels Jul 15, 2024
@BentiGorlich BentiGorlich self-assigned this Jul 15, 2024
@BentiGorlich
Copy link
Member Author

@melroy89 does this fix your problem?

@ghost ghost requested a review from melroy89 July 17, 2024 13:29
melroy89
melroy89 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it fixed my problem actually!! I can reject it.

@BentiGorlich BentiGorlich enabled auto-merge (squash) July 19, 2024 09:48
@BentiGorlich BentiGorlich merged commit a9f1aa7 into main Jul 19, 2024
7 checks passed
@BentiGorlich BentiGorlich deleted the fix/reject-report-error branch July 19, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melroy89 melroy89 melroy89 approved these changes

Assignees

@BentiGorlich BentiGorlich

Labels
backend Backend related issues and pull requests bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reject of a report causes 500 error message
2 participants
@BentiGorlich @melroy89