Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subgen.py add queuing and threading. #85

Merged
merged 6 commits into from
Apr 21, 2024

Conversation

xhzhu0628
Copy link
Contributor

fix queuing .#51

@McCloudS
Copy link
Owner

McCloudS commented Apr 20, 2024

Thanks, my issue has always been overthinking it and trying to get queueing to also work with ASR/Detect-language.

My limited testing shows it following the queueing nicely.

Take a look and let me know what you think. I added a check under gen_subtitles_queue so it won't queue something unless it actually needs to work on it.

If CONCURRENT_TRANSCRIPTIONS is 1, it will continually re-create the model on completion (not a huge deal, just a second wasted reloading the model and spamming the log).

Also, the files_to_transcribe needs to continue to exist in its current instantiation because that's what is used to 'internally' track the files being worked on so we don't accidentally delete/purge the model while we're working on it (primarily from the ASR and detect-language side because they don't call gen_subtitles) Fixed this in latest

If we can figure out how to queue up the ASR/Detect-language as well, that would be great (or at least be aware when they are running).

@McCloudS
Copy link
Owner

Sorry for spamming your branch, trying to make edits on my phone.

General clean up, removed the old array that tracked items and added Bazarr.  Bazarr doesn't obey the CONCURRENT_TRANSCRIPTIONS, which is probably best since those have a fixed timeout they need to respond by.
@McCloudS McCloudS merged commit 37e2680 into McCloudS:main Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants