Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TextField for 1.14 #105

Merged
merged 3 commits into from
Dec 12, 2019
Merged

Fix TextField for 1.14 #105

merged 3 commits into from
Dec 12, 2019

Conversation

hnOsmium0001
Copy link
Contributor

@hnOsmium0001 hnOsmium0001 commented Sep 7, 2019 •
edited
Loading

  • Replace LWJGL Keyboard with GLFW
  • Split 1.12 input logic into charTyped event
  • Add moving cursor by words when pressing down the control key
    • See ctrl + arrow keys in browser

@hnOsmium0001
Add charTyped event; fix TextField (untested)
8f64f45 
- replace LWJGL Keyboard with GLFW
- split 1.12 input logic into charTyped event
@hnOsmium0001 hnOsmium0001 marked this pull request as ready for review September 17, 2019 01:18
@McJty
Copy link
Collaborator

McJty commented Nov 20, 2019

Why did you close this? I must admit I didn't notice it as first but is it no longer relevant?

@hnOsmium0001
Copy link
Contributor Author

Since you updated TextField.java I just assumed all issues has been fixed (didn't bother to open it up XD). It seems like there is a few more problems: so I will reopen it
Don't have time right now but I will revisit it in a few days.

@hnOsmium0001 hnOsmium0001 reopened this Nov 20, 2019
@McJty
Copy link
Collaborator

McJty commented Nov 20, 2019

Ok thanks. And sorry for not looking at it earlier. I simply somehow didn't notice :-)

@hnOsmium0001
Merge branch '1.14' into gui/FixTextField
a24d51c 
# Conflicts:
#	src/main/java/mcjty/lib/gui/GenericGuiContainer.java
#	src/main/java/mcjty/lib/gui/WindowManager.java
#	src/main/java/mcjty/lib/gui/widgets/AbstractWidget.java
#	src/main/java/mcjty/lib/gui/widgets/TextField.java
#	src/main/java/mcjty/lib/gui/widgets/Widget.java
@hnOsmium0001
Add moving cursor between words surrounded by whitespaces
9d61826
@hnOsmium0001
Copy link
Contributor Author

hnOsmium0001 commented Nov 22, 2019 •
edited
Loading

I not really sure how would I test this, adding RFTools Utilities in run/mods will crash the game by

java.lang.NoSuchFieldError: field_176600_a
    at mcjty.rftoolsutility.setup.ClientRegistration.onModelBake(ClientRegistration.java:61)

If you can test this on your side that would be great! Note that the separate logic are working in my own mod, just not sure how would it work with this GUI system. Hopefully there won't be too much problem :)

Forgot forge no longer does automatic deobfuscation for mods in .minecraft/mods

Also #98 has been open for a long time too, you might want to check it out (it is basically the same addition as this PR but for 1.12.2)

@hnOsmium0001
Copy link
Contributor Author

@McJty?

@McJty
Copy link
Collaborator

McJty commented Nov 25, 2019

Sorry, been a bit busy. I'll check it out soon

@McJty
Copy link
Collaborator

McJty commented Dec 1, 2019

I haven't forgotten this. But I first want to concentrate on fixing some of the issues in my latest batch of changes before I check this

@McJty McJty merged commit 4f68c84 into McJtyMods:1.14 Dec 12, 2019
@hnOsmium0001 hnOsmium0001 deleted the gui/FixTextField branch December 12, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hnOsmium0001 @McJty