Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mermaid: update to 10.2.0 #499

Closed
meredrica opened this issue Mar 9, 2023 · 3 comments
Closed

mermaid: update to 10.2.0 #499

meredrica opened this issue Mar 9, 2023 · 3 comments
Assignees
Labels
task Maintainence work
Milestone

Comments

@meredrica
Copy link

Hello!

Mermaid is still on version 9.2.2, latest is 10.0.2. Is it possible to upgrade it easily?
An easy fix is to include

<script type="module">
import mermaid from 'https://cdn.jsdelivr.net/npm/mermaid@10.0.2/+esm'
</script>

in the footer partial but that's using a CDN and i don't know what it will break inside the theme.

@McShelby
Copy link
Owner

McShelby commented Mar 9, 2023

and i don't know what it will break inside the theme.

That's the reason why I haven't updated it yet. There were changes to the initialization code of Mermaid, so I first have to test it.

Anyways you can load Mermaid from a CDN by setting the config option customMermaidURL either in your config.toml for the whole site or in the Frontmatter of your page.

@McShelby McShelby added the task Maintainence work label Mar 14, 2023
@McShelby McShelby changed the title update mermaid mermaid: update to 10.x Mar 14, 2023
@McShelby McShelby added blocked Depends on other issue to be fixed first mermaid This is a topic related to Mermaid itself but not the theme browser This is a topic related to the browser but not the theme and removed mermaid This is a topic related to Mermaid itself but not the theme labels May 19, 2023
@McShelby
Copy link
Owner

Mermaid >= 10 only supprts ESM. As long as the theme still supports Internet Explorer 11, this would break.

So we are currently locked to Mermaid < 10.

@McShelby McShelby removed blocked Depends on other issue to be fixed first browser This is a topic related to the browser but not the theme labels May 24, 2023
@McShelby
Copy link
Owner

Well, just today, Mermaid 10.2.0 was released, reintroducing UMD support which makes mermaid.min.js available again.

So it is just need to check for the initialization before we can bump.

@McShelby McShelby changed the title mermaid: update to 10.x mermaid: update to 10.2.0 May 24, 2023
@McShelby McShelby self-assigned this May 24, 2023
@McShelby McShelby added this to the 5.15.0 milestone May 24, 2023
McShelby added a commit that referenced this issue May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Maintainence work
Projects
None yet
Development

No branches or pull requests

2 participants