Fix macOS and CentOS CI #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@he-hesce - I think you are the one most interested in the CentOS builds. Can you have a look? |
mrbean-bremen
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Looks good to me, thanks! Just waiting for @he-hesce to comment.
|
Looks good to me. RHEL 7 is still supported for several more years but we need the CentOS 7 container for testing on GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS7 reached EOL and GHA support for the corresponding container was abandoned. However,
node20requires at leastglibc2.27, which is not available in CentOS, but upgrading the glibc version contradicts the meaning of using older CentOS. The proposed solution in this PR is to use corresponding environment variable, that helps to extend CentOS CI availability for some time. Also,mirrorlist.centos.orgwas turned off, so switch to vault is required (seesedfor configs in PR)macOS-11 runner is no longer supported on GHA, thus macOS-12 with python3.9 is proposed
Small feature: cancel running workflow from the same PR.