Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

MAT-4981 remove measure report from export #2106

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Conversation

adongare
Copy link
Contributor

@adongare adongare commented Oct 26, 2022

MAT-4981 remove measure report from export

Pull requests into Bonnie require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • This PR is into the correct branch.
  • JIRA ticket for this PR: MAT-4981
  • JIRA ticket links to this PR
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
  • Tests are included and test edge cases
  • Tests have been run locally and pass (remember to update Gemfile when applicable)
  • Test fixtures updated and documented as necessary ( see internal wiki )
  • Code coverage has not gone down and all code touched or added is covered.
    • In rare situations, this may not be possible or applicable to a PR. In those situations:
      1. Note why this could not be done or is not applicable here:
      2. Add TODOs in the code noting that it requires a test
      3. Add a JIRA task to add the test and link it here:
  • Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

  • JIRA test links:
  • Justification for using JIRA tests:
  • JIRA tests have been added to sprint

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #2106 (9bc8548) into bonnie-on-fhir (bfa0093) will increase coverage by 28.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           bonnie-on-fhir    #2106       +/-   ##
===================================================
+ Coverage           41.02%   69.32%   +28.30%     
===================================================
  Files                 196      196               
  Lines               10662    10657        -5     
  Branches             1270     1270               
===================================================
+ Hits                 4374     7388     +3014     
+ Misses               6084     2665     -3419     
- Partials              204      604      +400     
Impacted Files Coverage Δ
app/assets/javascripts/models/patient.js.coffee 64.24% <0.00%> (+15.33%) ⬆️
app/assets/javascripts/models/result.js.coffee 18.95% <0.00%> (+0.80%) ⬆️
.../javascripts/helpers/cql_measure_helpers.js.coffee 74.85% <0.00%> (+1.14%) ⬆️
app/assets/javascripts/views/breadcrumb.js.coffee 37.77% <0.00%> (+2.22%) ⬆️
...iews/logic/cql_statement_result_box_view.js.coffee 57.69% <0.00%> (+3.84%) ⬆️
app/assets/javascripts/helpers.js.coffee 38.88% <0.00%> (+4.16%) ⬆️
app/assets/javascripts/models/coverage.js.coffee 96.92% <0.00%> (+4.61%) ⬆️
.../javascripts/helpers/cql_results_helpers.js.coffee 87.27% <0.00%> (+5.45%) ⬆️
app/assets/javascripts/models/difference.js.coffee 85.18% <0.00%> (+5.55%) ⬆️
...scripts/views/logic/cql_statement_result.js.coffee 70.58% <0.00%> (+5.88%) ⬆️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfa0093...9bc8548. Read the comment docs.

@adongare adongare marked this pull request as ready for review October 26, 2022 22:03
@adongare adongare requested a review from a team as a code owner October 26, 2022 22:03
@adongare adongare merged commit a120d4a into bonnie-on-fhir Oct 27, 2022
@adongare adongare deleted the MAT-4981 branch October 27, 2022 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants