Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

update bootstrap version to v3.3.4 #450

Merged
merged 2 commits into from
May 1, 2015
Merged

update bootstrap version to v3.3.4 #450

merged 2 commits into from
May 1, 2015

Conversation

thecristen
Copy link
Contributor

and be more selective about importing bootstrap's LESS files into our own CSS

Story

https://www.pivotaltracker.com/story/show/91736682

Notes

Tooltips are no longer wedged left.
Instead of importing the entire bootstrap.less, I changed application.css.less to import only the components utilized by Bonnie. Bootstrap components excluded:

  • glyphicons.less
  • code.less
  • pagination.less
  • pager.less
  • labels.less
  • badges.less
  • thumbnails.less
  • media.less
  • responsive-embed.less
  • carousel.less
    This keeps the application.css file small enough to not run into problems in IE9.

and be more selective about importing bootstrap's LESS files into our own CSS
@jtferns
Copy link
Contributor

jtferns commented Apr 28, 2015

The value sets White/Black List builder utilizes the following, so we probably want to keep them around:

  • labels.less
  • badges.less

@thecristen
Copy link
Contributor Author

@jtferns sounds good!

@jtferns
Copy link
Contributor

jtferns commented May 1, 2015

This looks good throughout the app (nothing is broken or missing, white/black list has badges and labels now).

jtferns added a commit that referenced this pull request May 1, 2015
@jtferns jtferns merged commit 13d8dee into master May 1, 2015
@pkmitre pkmitre deleted the update_bootstrap branch March 17, 2016 20:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants