Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured data fields from NT4 do not get decoded #103

Closed
mjansen4857 opened this issue Oct 31, 2023 · 1 comment
Closed

Structured data fields from NT4 do not get decoded #103

mjansen4857 opened this issue Oct 31, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@mjansen4857
Copy link

mjansen4857 commented Oct 31, 2023

Describe the bug
Not sure if this is intentional or not, but I didn't see anything in the docs mentioning this.

When logging stuff over network tables using the new structured data support, i.e. a Pose2d object, it will show up in AdvantageScope, but will never be decoded or displayed when used.

After logging a Pose2d like so:

Logger.recordOutput("Swerve/Odom", new Pose2d(3.0, 3.0, new Rotation2d()));

The pose is showing up as a Pose2d struct properly:
image

And is recognized as such in AdvantageScope, but will never actually be displayed when used:
image
Also notice how there is no dropdown for that field to use the translation or rotation components as shown in the docs.

I have not been able to get any of the supported data types to be displayed in any of the tabs over network tables. They do work fine when using a log file.

Version (required):
AdvantageScope 3.0.0-beta-4 and AdvantageKit 3.0.0-beta-1.
I also noticed this with AdvantageScope beta 3.

@mjansen4857 mjansen4857 added the bug Something isn't working label Oct 31, 2023
@jwbonner
Copy link
Member

Turns out the fixes I made to structs for beta 4 missed an obvious problem. This is actually a simple issue with the combination of the non-AdvantageKit NT mode (with AdvantageKit data) and low bandwidth NT mode since AdvantageKit publishes schemas to a different subtable. 72d7110 fixes this.

The workarounds until the next release would be to switch to either the AdvantageKit NT mode or logging NT mode. If any of the desired data types are published anywhere in NT in addition to AdvantageKit that should also work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants