Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta: 3D Field Widget Lagging with Table Widget #200

Closed
catr1xLiu opened this issue Sep 26, 2024 · 1 comment
Closed

Beta: 3D Field Widget Lagging with Table Widget #200

catr1xLiu opened this issue Sep 26, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@catr1xLiu
Copy link

catr1xLiu commented Sep 26, 2024

Describe the bug
When using the table view widget and the 3d field widget together, the 3d field widget seems to be lagging.

To Reproduce
1.Open any log file
2. Drag some poses to the 3d field widget.
3. Open the 3d field widget in a sperate window
4. In the main window, switch to "table view" and open some tables
5. If the table is rolling down too fast, the field3d widgets gets extremely laggy.

Screenshots
image

Version
Version: 4.0.0-beta-1
Distributor: FRC 6328
Platform: win32-x64
Build Date: 9/26/2024, 24:41:47 UTC
Electron: 32.0.2
Chromium: 128.0.6613.84
Node: 20.16.0

Aditional Context
Running on a Windows10 Laptop, with R7-8845HS CPU and 32GB Memory.
There is NO performance issue when running 3d field widget alone.

@catr1xLiu catr1xLiu added the bug Something isn't working label Sep 26, 2024
@catr1xLiu catr1xLiu changed the title 3D Field Widget Lagging with Table Widget Beta: 3D Field Widget Lagging with Table Widget Sep 26, 2024
@jwbonner
Copy link
Member

It looks like the table tab was a performance bottleneck, which prevented updates to the 3D field. I tracked down the issue and swapped a call from innerText to textContent, which should be a ~15x performance improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants