Warn about fixed length Photon arrays instead of throwing #274
Conversation
Fixed length arrays are supported by non-Photon structs, which still need to be compiled by PhotonStructDecoder. This isn't an actual issue unless a Photon struct tries to use a struct with an unsupported array. Returning false just indicates that the schema cannot be compiled or used in parent schemas.
|
@mcm001 Does this seem like a reasonable solution? |
|
Maybe skull issue on my part but why does PhotonStructDecoder need to parse non-photon types? |
|
I'm cool with whatever unbreaks us for now, and I'll dig into the new issue when I get home to establish an MVP to reproduce |
|
My understanding is that Photon structs can have normal structs nested within them? If Photon publishes its own versions of the geometry types, this whole issue could be sidestepped by separating them. There's no rush on this, we just did a beta release a few days ago so it will probably be a little while. |
|
Ah yep you're right. We do support VLAs of wpilib struct types within our messages, provided that those nested wpilib types do not themselves contain any fixed length arrays. Honestly? Maybe I should just make photon structs support fixed length arrays. It's kinda silly to force everyone to use VLAs lol |
|
In the meantime we should send this one though lol |
Fixed length arrays are supported by non-Photon structs, which still need to be compiled by PhotonStructDecoder. This isn't an actual issue unless a Photon struct tries to use a struct with an unsupported array. Returning false just indicates that the schema cannot be compiled or used in parent Photon schemas.
Fixes #273