Core/Movie: Refactor to class, move to System. #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bit of global state remains (the `header` in `BeginRecordingInput()`) due to unclear lifetime requirements.
These functions were removed in PR #9624 - Add new "input override" system for TAS input and Android touch controls in Dolphin Original. MMJR2 retains the original code. I have to remove these functions to fix building. I will try to rewrite the code and add them back. This shouldn´t affect Android build in any way and QT version of MMJR2 ihas been most likely broken for a very long time, no one is building and testing it anyway.
I re-added the previously removed functions. It was most likely not necessary, the Android build should not be affected and Qt is probably broken anyway. This builds fine, needs some further testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Add new "input override" system for TAS input and Android touch controls" refactored TAS input and Android touch controllers and also removed GCInputManipFunction and WiiInputManipFunction. I have not ported this PR into MMJR2 codebase, so these lingering functions caused compilation error. I first removed them completely and then refactored them and added them back. This was probably unnecessary, because it shouldn´t affect Android build in any way and Qt build of MMJR2 is probably broken anyway, because no one is actively testing it.