Merge pull request #467 from JeromeMartinez/Checks

Checks database: add test on MP4/moov/trak/tkhd/track_ID reuse
MediaArea · Jun 22, 2023 · d902da5 · d902da5
2 parents 0848e7e + 61ff8d7
commit d902da5
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/MediaConchBundle/Lib/Checks/Checks.php b/src/MediaConchBundle/Lib/Checks/Checks.php
@@ -1090,6 +1090,19 @@ public function __construct($specId = null, $elementId = null, $fieldId = null,
         null,
         [ 'Audio_Coding_Syntax', ]
     ),
+    new Check(
+        '<code>(field)</code> <code>(value)</code> is already used by another <code>(item)</code>',
+        'Error',
+        [
+            new Reference(
+                'ISO_IEC_14496-12',
+                'moov/trak/tkhd',
+                'track_ID',
+                '"Track IDs are never re‐used and cannot be zero."',
+                'Fix the encoder to correctly fill <code>track_ID</code>, then remux the content.'
+            ),
+        ]
+    ),
 ];
 
 $GLOBALS['dbFormatToSpecs'] =

diff --git a/src/MediaConchBundle/Lib/Checks/Specs.php b/src/MediaConchBundle/Lib/Checks/Specs.php
@@ -224,6 +224,14 @@ public function __construct($description = null)
                     ),
                 ]
             ),
+            'moov/trak/tkhd' => new Element(
+                'Track Header',
+                [
+                    'track_ID' => new Field(
+                        'an integer that uniquely identifies this track over the entire life‐time of this presentation'
+                    ),
+                ]
+            ),
             'AudioSampleEntry' => new Element(
                 null,
                 [