Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows GUI dark mode: avoid an unexpected popup 2 #852

Merged
merged 1 commit into from
May 31, 2024

Conversation

JeromeMartinez
Copy link
Member

@JeromeMartinez JeromeMartinez merged commit 56efc1a into MediaArea:master May 31, 2024
3 checks passed
@JeromeMartinez JeromeMartinez deleted the DarkMode_fix branch May 31, 2024 06:29
@cjee21
Copy link
Collaborator

cjee21 commented May 31, 2024

@JeromeMartinez turns out the new PR that I'm going to make (soon) addresses the root cause of all the dark mode switching bugs. This and #851 is no longer needed with the new PR.

@JeromeMartinez
Copy link
Member Author

This and #851 is no longer needed with the new PR.

We do a release today with them as a workaround, we don't want to block the release but it will be in the next one.

turns out the new PR that I'm going to make (soon) addresses the root cause of all the dark mode switching bugs.

It would be great! I thought it was a limitation of C++ Builder but maybe it is not :).
Thank ou for taking care of that.

@cjee21
Copy link
Collaborator

cjee21 commented May 31, 2024

I can make it within an hour if you want to wait.

@JeromeMartinez
Copy link
Member Author

I can make it within an hour if you want to wait.

OK, we wait a bit.

@cjee21
Copy link
Collaborator

cjee21 commented May 31, 2024

Done. I make a PR for this main issue first and will look at whether it's possible for HTML view to have dark mode for future release.

@JeromeMartinez
Copy link
Member Author

[...] and will look at whether it's possible for HTML view to have dark mode for future release.

Your help is appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants