Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows GUI: Fix shell extension registries #968

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

cjee21
Copy link
Collaborator

@cjee21 cjee21 commented Nov 18, 2024

Fix bugs to prevent issues such as the following:
https://sourceforge.net/p/mediainfo/support-requests/51/
https://sourceforge.net/p/mediainfo/bugs/1161/

Make sure that associations other than for file extensions in MediaInfo's list are properly removed and no longer added.
Also refresh File Explorer's context menu after install/uninstall so changes are visible immediately.

Tests results:

  • Context menu entry appears immediately and for both files and folders after install without requiring MediaInfo to be launched first regardless of MediaInfo's existing settings.
  • When MediaInfo is launched, context menu is updated according to settings set.
  • If shell extension is disabled, context menu entry no longer shows for files associated with audio/video such as .mp3.
  • After uninstall, the registry was searched and it was found that some MediaInfo entries still remain. This should be retested after Update file extensions lists #967 is merged.

@JeromeMartinez
Copy link
Member

Context menu entry appears immediately and for both files and folders after install without requiring MediaInfo to be launched first regardless of MediaInfo's existing settings.

I didn't think to when user disabled it then install an update :(.
A nice to have in the NSI would be a test on the registry key, if it exist and 0, no extension installation/update (so install only at the first install)

If shell extension is disabled, context menu entry no longer shows for files associated with audio/video such as .mp3.

Thank you.

After uninstall, the registry was searched and it was found that some MediaInfo entries still remain. This should be retested after #967 is merged.

Please rebase.

Copy link
Member

@JeromeMartinez JeromeMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to rebase.

@JeromeMartinez JeromeMartinez merged commit 176c465 into MediaArea:master Nov 18, 2024
3 checks passed
@cjee21 cjee21 deleted the shell-ext branch November 18, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants