Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust parsing of app.allowed_env_substitutions #304

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

beiertu-mms
Copy link
Contributor

@beiertu-mms beiertu-mms commented Jan 11, 2024

SmallRyeConfig getValue doesn't allow the provided configured value to
be empty, therefore use getOptionalValue instead.

See also: eclipse/microprofile-config#407

Fixes #303

@technolinator-sbom-as-a-service
Copy link

technolinator-sbom-as-a-service bot commented Jan 11, 2024

Vulnerability Report

Please consider this as a tentative appraisal, consult Dependency-Track for reliable results.

Artifact Vulnerability Severity (CVSS v3) Recommendation
pkg:maven/com.fasterxml.jackson.core/jackson-databind@2.15.3?type=jar
CVE-2023-35116jackson-databind through 2.15.2 allows attackers to cause a denial of service or other unspecified impact via a crafted object that uses cyclic dependencies. NOTE: the vendor's perspective is that this is not a valid vulnerability report, because the steps of constructing a cyclic data structure and trying to serialize it cannot be achieved by an external attacker.
🟡 Medium (4.7) Update to 2.16.0 or later

SmallRyeConfig getValue doesn't allow the provided configured value to
be empty, therefore use getOptionalValue instead.

See also: eclipse/microprofile-config#407

Fixes #303
@beiertu-mms beiertu-mms force-pushed the fix/fix-config-parsing-error branch from 78675b6 to 4154266 Compare January 11, 2024 10:59
Copy link
Member

@heubeck heubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@beiertu-mms beiertu-mms marked this pull request as ready for review January 11, 2024 11:34
@beiertu-mms beiertu-mms requested a review from a team as a code owner January 11, 2024 11:34
@beiertu-mms beiertu-mms changed the title fix: fix allowed_env_substitutions parsed error fix: adjust parsing of app.allowed_env_substitutions Jan 11, 2024
@beiertu-mms beiertu-mms enabled auto-merge (squash) January 11, 2024 11:44
@beiertu-mms beiertu-mms merged commit 1936dda into main Jan 11, 2024
1 check passed
@beiertu-mms beiertu-mms deleted the fix/fix-config-parsing-error branch January 11, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ALLOWED_ENV_SUBSTITUTIONS cannot be empty
2 participants