Unreliable lookup method used within LBLEEventDispatcher class #89
Assignees
Comments
|
Thanks for report this! We will investigate further into this issue. |
|
Will use |
pablosun
added a commit
that referenced
this issue
Feb 14, 2018
* #89: use `equal_range` when searching for elements in STL multimap, instead of using `find`. `find` is not guaranteed to return the first element in the equal range. * #90: Add a new set of interfaces to `LBLEClient` that allows user to identify a characteristic by using service index and characteristic index, instead of using UUID. Note that it is possible for a device to have multiple characteristics with the same UUID. * #90: Add a new example `EnumerateCharacteristic.ino` that uses the new indices-based interface of `LBLEClient` to list all the services and characteristics in the connected BLE device. * #90: Use `bt_gattc_read_charc` instead of `bt_gattc_read_using_charc_uuid` to read characteristics. * #91: when calling `bt_gattc_discover_charc`, we need to wait for multiple `BT_GATTC_DISCOVER_CHARC` event. We added new helper function `waitAndProcessEventMultiple` that supports such event waiting behavior. * Refactored `LBLEValueBuffer` to support re-interpreting its raw buffer content into String, float, int, and char types.
Merged
pablosun
added a commit
that referenced
this issue
Feb 26, 2018
## Bug Fixes * #89: use `equal_range` when searching for elements in STL multimap, instead of using `find`. `find` is not guaranteed to return the first element in the equal range. * #90: Add a new set of interfaces to `LBLEClient` that allows user to identify a characteristic by using service index and characteristic index, instead of using UUID. Note that it is possible for a device to have multiple characteristics with the same UUID. * #90: Add a new example `EnumerateCharacteristic.ino` that uses the new indices-based interface of `LBLEClient` to list all the services and characteristics in the connected BLE device. * #90: Use `bt_gattc_read_charc` instead of `bt_gattc_read_using_charc_uuid` to read characteristics. * #91: when calling `bt_gattc_discover_charc`, we need to wait for multiple `BT_GATTC_DISCOVER_CHARC` event. We added new helper function `waitAndProcessEventMultiple` that supports such event waiting behavior. * Refactored `LBLEValueBuffer` to support re-interpreting its raw buffer content into String, float, int, and char types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the LBLEEventDispatcher class defined in LBLE.h and implemented in LBLE.cpp, the EventTable type is a std::multimap container, and the implementation of both the
dispatch()and theremoveObserver()methods usesstd::multimap::find()method to lookup the iterator to the first element in them_tablelist.However, according to the C++ standard, the
std::multimap::find()method does NOT guarantee to return the iterator of the first element for elements of the same key in the list, so the outcome of the these two methods could be STL-implementation-dependent.A possible workaround could be replacing the
std::multimap::find()method calls withstd::multimap::lower_bound(), which returns an iterator pointing to the first element that is not less than the specified key.The text was updated successfully, but these errors were encountered: