This repository has been archived by the owner on Jul 24, 2019. It is now read-only.
Updating request module version #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**request@2.40.0** was released to fix a recent security issue w/ **qs**. See request/request#992 and https://blog.liftsecurity.io/2014/08/06/denial-of-service-in-qs
Steps to reproduce$ git clone git@github.com:Medium/phantomjs.git .
$ npm i
$ npm shrinkwrap --dev
wrote npm-shrinkwrap.json
$ [sudo] npm i nsp -g
$ nsp shrinkwrap
Name Installed Patched Vulnerable Dependency
qs 0.6.6 >= 1.x phantomjs > request |
|
Link to eslint/eslint#1149 |
|
just to verify, this is only a security issue if we pass untrusted urls to qs, right? |
|
No clue, there was also https://nodesecurity.io/advisories/qs_dos_memory_exhaustion recently as well as https://nodesecurity.io/advisories/qs_dos_extended_event_loop_blocking recently (which is why request was updated). I was mainly filing it because our project's build task was failing the Travis build because of vulnerable modules in dependencies. |
|
ya, looking at it, i don't think this is a real issue, but there's no harm in updating. |
|
thanks for the patch |
This was referenced Aug 14, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request@2.40.0 was released to fix a recent security issue w/ qs. See request/request#992 and https://blog.liftsecurity.io/2014/08/06/denial-of-service-in-qs