Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] 포트폴리오 메인이미지 변경 오류 해결 #388

Merged
merged 1 commit into from
Aug 8, 2024
Merged

[FIX] 포트폴리오 메인이미지 변경 오류 해결 #388

merged 1 commit into from
Aug 8, 2024

Conversation

Goder-0
Copy link
Member

@Goder-0 Goder-0 commented Aug 8, 2024

📝 PR 타입

  • 기능 추가
  • 기능 수정
  • 기능 삭제
  • 리팩토링
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트

📝 반영 브랜치

📝 변경 사항

  • 기존 포트폴리오 수정 api에 mainImageFileName을 받아오도록 스펙을 추가하였습니다.
  • 프론트에서는 이미 요청에 담아 보내도록 했다고 합니다.

📝 테스트 결과

image
image
image

📝 To Reviewer

@Goder-0 Goder-0 requested a review from mikekks August 8, 2024 07:54
@Goder-0 Goder-0 self-assigned this Aug 8, 2024
@Goder-0 Goder-0 linked an issue Aug 8, 2024 that may be closed by this pull request
[FIX] 포트폴리오 메인 이미지 변경 오류 해결 #387
Closed
1 task
mikekks
mikekks approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@mikekks mikekks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !!

@Goder-0 Goder-0 merged commit f601705 into develop Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikekks mikekks mikekks approved these changes

Assignees

@Goder-0 Goder-0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 포트폴리오 메인 이미지 변경 오류 해결
2 participants
@Goder-0 @mikekks