Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Banner and Sidebar Sections CSS Computing from XML - MEED-8340 - Meeds-io/MIPs#175 #1047

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

boubaker
Copy link
Member

@boubaker boubaker commented Feb 4, 2025

Prior to this change, the CSS Classes of Margins in Site Layout Sections was computed as it was an application Margin. This change will ensure to differentiate Section Margins computing from Applications Margin Computing.

… - Meeds-io/MIPs#175

Prior to this change, the CSS Classes of Margins in Site Layout Sections was computed as it was an application Margin. This change will ensure to differentiate Section MArgins computing from Applications Margin Computing.
@boubaker boubaker merged commit aba0d50 into feature/whitepaper Feb 4, 2025
2 of 3 checks passed
@boubaker boubaker deleted the meed-8340 branch February 4, 2025 12:23
boubaker added a commit that referenced this pull request Feb 4, 2025
… - Meeds-io/MIPs#175 (#1047)

Prior to this change, the CSS Classes of Margins in Site Layout Sections
was computed as it was an application Margin. This change will ensure to
differentiate Section Margins computing from Applications Margin
Computing.
boubaker added a commit that referenced this pull request Feb 4, 2025
… - Meeds-io/MIPs#175 (#1047)

Prior to this change, the CSS Classes of Margins in Site Layout Sections
was computed as it was an application Margin. This change will ensure to
differentiate Section Margins computing from Applications Margin
Computing.
exo-swf pushed a commit that referenced this pull request Feb 5, 2025
… - Meeds-io/MIPs#175 (#1047)

Prior to this change, the CSS Classes of Margins in Site Layout Sections
was computed as it was an application Margin. This change will ensure to
differentiate Section Margins computing from Applications Margin
Computing.
boubaker added a commit that referenced this pull request Feb 6, 2025
… - Meeds-io/MIPs#175 (#1047)

Prior to this change, the CSS Classes of Margins in Site Layout Sections
was computed as it was an application Margin. This change will ensure to
differentiate Section Margins computing from Applications Margin
Computing.
exo-swf pushed a commit that referenced this pull request Feb 6, 2025
… - Meeds-io/MIPs#175 (#1047)

Prior to this change, the CSS Classes of Margins in Site Layout Sections
was computed as it was an application Margin. This change will ensure to
differentiate Section Margins computing from Applications Margin
Computing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant