Expose utils from Web3 class as static property #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pknuth
reviewed
Mar 12, 2019
| * | ||
| * @returns {Object} Utility functions for Ethereum dapps | ||
| */ | ||
| static get utils() { |
There was a problem hiding this comment.
I guess the place is wrong, static's seem to be below
| @@ -37,7 +37,7 @@ export default class Web3 extends AbstractWeb3Module { | |||
| static modules: Modules; | |||
| static readonly givenProvider: provider | null; | |||
|
|
|||
| utils: Utils; | |||
| static readonly utils: Utils; | |||
There was a problem hiding this comment.
I guess this isn't needed since we have static function instead of property?
pknuth
suggested changes
Mar 12, 2019
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Utilities are now static readonly property of Web3 class. This is not breaking change and no change in implementation is needed.
Typing test adjusted.
Web3 tests supplemented with test case.
Missing utilities added to utils property of Web3 class:
isBigNumber(): addedleftPad(): added for compatibility with TS InterfacerightPad(): added for compatibility with TS InterfaceunitMap(): addedKnown issues:
testAddress(): defined but implementation is missingtestTopic(): defined but implementation is missingboth methods do not exist in documentation of version 1.0.
Type of change
Checklist:
npm run testin the root folder with success and extended the tests if necessary.npm run buildin the root folder and tested it in the browser and with node.npm run dtslintin the root folder and tested that all my types are correct