1단계 미션 제출합니다. #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksy90101
requested changes
Jul 8, 2024
Comment on lines
11
to
21
| public List<Integer> generateRandomDigits() { | ||
| List<Integer> digits = new ArrayList<>(); | ||
|
|
||
| while (digits.size() < COMPUTER_DIGITS_SIZE) { | ||
| Random random = new Random(); | ||
| int randomNumber = random.nextInt(9) + 1; | ||
| addToDigits(digits, randomNumber); | ||
| } | ||
|
|
||
| return digits; | ||
| } |
There was a problem hiding this comment.
이러면 테스트하기가 어려운거 같습니다.
https://tecoble.techcourse.co.kr/post/2020-05-17-appropriate_method_for_test_by_interface/
이글을 참고해서 한번 변경해보면 어떨까요?
There was a problem hiding this comment.
이걸 변경하면 테스트 코드를 많이 추가할수 있을거 같아요.
There was a problem hiding this comment.
숫자 생성을 외부에서 주입 받게 변경해봤습니다. 랜덤 주입이 아닐 경우에 무한루프를 타게 되는데, 코드를 변경할지 고민하다가 '비정상일때는 무한루프를 돈다' 이걸 검증하는 테스트 코드를 만들어봤습니다. 특정 시간안에 끝나지 못하면 무한루프라 판정하고 테스트를 성공으로 종료하게 만들었는데요. 이런식으로 구현해도 괜찮을까요 ??
Comment on lines
7
to
9
| private static final String BALL_CALL = "볼"; | ||
| private static final String STRIKE_CALL = "스트라이크"; | ||
| private static final String NOTHING_CALL = "낫싱"; |
There was a problem hiding this comment.
이런 경우 enum을 이용해보는것도 방법일거 같아요.
|
|
||
| import java.util.List; | ||
|
|
||
| public class Referee { |
There was a problem hiding this comment.
한번 PlayerBalls를 만들고 Ball이라는것을 객체로 만들어보면 어떨까요?
좀더 객체지향적인 설계를 해보면 좋을거 같습니다.
There was a problem hiding this comment.
컴퓨터와 유저가 입력한 숫자들을 저장할 수 있는 객체들을 추가해봤습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요! 리뷰 부탁드립니다 :)