Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.50] Structure Collapse Warning Appearing Beneath Objects #5219

Closed
IllianiCBT opened this issue Mar 5, 2024 · 4 comments · Fixed by #5263 or #5947
Closed

[0.50] Structure Collapse Warning Appearing Beneath Objects #5219

IllianiCBT opened this issue Mar 5, 2024 · 4 comments · Fixed by #5263 or #5947
Assignees
@HoneySkull

Comments

@IllianiCBT
Copy link
Collaborator

Environment

HQ MegaMek
Mac Ventura 13.6.4
Java Homebrew 11.0.16.1

Description

Structure collapse warning symbols appear beneath bridges, when isometric view is enabled.

Isometric View On
image

Isometric View Off
image
@IllianiCBT
Copy link
Collaborator Author

Player: The Oddballs
IllianiCBT_#5219.sav.gz

@IllianiCBT
Copy link
Collaborator Author

IllianiCBT commented Mar 5, 2024 •
edited
Loading

This is also true for buildings with turrets:

Isometric view on:
image

Isometric view off:
image

Player: The Oddballs
IllianiCBT_#5219_2.sav.gz

@IllianiCBT IllianiCBT changed the title [0.49.18] Structure Collapse Warning Appearing Beneath Bridges [0.49.18] Structure Collapse Warning Appearing Beneath Objects Mar 5, 2024
@HoneySkull HoneySkull self-assigned this Mar 19, 2024
HoneySkull added a commit to HoneySkull/megamek that referenced this issue Mar 19, 2024
@HoneySkull
Show CF Warning over isometric bridges and turrets. Fixes MegaMek#5219
f11ca07
@HoneySkull HoneySkull mentioned this issue Mar 19, 2024
Merged
HammerGS added a commit that referenced this issue Mar 19, 2024
@HammerGS
Merge pull request #5263 from HoneySkull/cf_warning_iso_visibility
ffbe61e 
Show CF Warning over isometric bridges and turrets. Fixes #5219
HammerGS added a commit that referenced this issue Mar 19, 2024
@HammerGS
Merging the following PR's
5808376 
+ PR #5259: Refactor code to add new units to a C3 network
+ PR #5257: Flat Darcula skin
+ PR #5256: Bind escape to the close action on various dialogs
+ Fix #5219: Show CF Warning over isometric bridges and turrets.
@IllianiCBT IllianiCBT changed the title [0.49.18] Structure Collapse Warning Appearing Beneath Objects [0.49.19.1] Structure Collapse Warning Appearing Beneath Objects Jun 24, 2024
@IllianiCBT IllianiCBT changed the title [0.49.19.1] Structure Collapse Warning Appearing Beneath Objects [0.49.18] Structure Collapse Warning Appearing Beneath Objects Jun 24, 2024
@IllianiCBT IllianiCBT reopened this Aug 25, 2024
@IllianiCBT
Copy link
Collaborator Author

This appears to have suffered a regression :(

@IllianiCBT IllianiCBT changed the title [0.49.18] Structure Collapse Warning Appearing Beneath Objects [0.50] Structure Collapse Warning Appearing Beneath Objects Aug 25, 2024
@HoneySkull
Copy link
Collaborator

This regression appears to have occurred after the sprite refactoring that separated sprite logic from BoardView.java and is broke in 0.49.20. It's working as expected in 0.49.19.1

@HoneySkull HoneySkull mentioned this issue Aug 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HoneySkull HoneySkull

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@HoneySkull @IllianiCBT