Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.49.19 Nightly] (UI Bug) Damage boxes not showing red when displaying multiples of damage #5343

Closed
PhoenixHeart512 opened this issue Apr 10, 2024 · 4 comments · Fixed by #5371
Assignees
Labels
Bug Unit Display Deals with the in-game unit display window

Comments

@PhoenixHeart512
Copy link

Environment

megamek.MegaMek.initializeLogging(MegaMek.java:118) - Starting MegaMek v0.49.19-SNAPSHOT
Build Date: 2024-04-09T01:08:56.721120
Today: 2024-04-10
Origin Project: MegaMek
Java Vendor: Eclipse Adoptium
Java Version: 17.0.6
Platform: Windows 10 10.0 (amd64)
System Locale: en_US
Total memory available to MegaMek: 8 GB

Description

When a unit has more armor than can be displayed with individual boxes, MegaMek uses groupings, such as showing "[]x20"

When doing this for damaged armor boxes, they show green instead of red. When only showing individuals, the boxes show red as expected, this only occurs when they are grouped (such as having a large amount of damage on a dropship, as seen in the screenshot below)

Files

DamageBoxesBug

DamageBoxesBug.sav.gz

@kuronekochomusuke kuronekochomusuke added Unit Display Deals with the in-game unit display window Bug labels Apr 10, 2024
@Sleet01 Sleet01 self-assigned this Apr 16, 2024
@Sleet01
Copy link
Collaborator

Sleet01 commented Apr 17, 2024

BTW, I note that this DropShip is showing the "5/8 ・2/2 ・ Wheeled" bug as well.

... or is it landed?

@gsparks3
Copy link
Collaborator

You can see the multihex graphic, which means it's landed.

@Sleet01
Copy link
Collaborator

Sleet01 commented Apr 17, 2024

You can see the multihex graphic, which means it's landed.

You're giving my tired old view-orbs too much credit, but after reviewing the picture I see what you mean :)

@Sleet01
Copy link
Collaborator

Sleet01 commented Apr 18, 2024

@PhoenixHeart512 Okay, I was finally able to repro the issue by setting "Armor Units per Block" in Client Settings -> Unit Tooltip / Unit Display to "5" (half its default value of "10").

...dangit, I thought there would be an esoteric math error but it's just using the wrong variable in one place -_-;

image

Sleet01 added a commit to Sleet01/megamek that referenced this issue Apr 18, 2024
Sleet01 added a commit that referenced this issue Apr 18, 2024
…wing_damage_color_for_multiples_of_damage

Fix #5343: damage display not showing damage color when multiples used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unit Display Deals with the in-game unit display window
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants