Dockable unit detail (with fixes) #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This doesn't include the previous changes |
mjog
force-pushed
the
dockable-unit-detail
branch
from
0f9b2e7 to
bcfc787
Compare
|
Needed to revert the revert and rebase off of that. Fixed the illegal char. |
|
Just the icon for light/dark mode, then I think this can be merged (again). |
|
Updated version that fixes a layout issue and uses text labels instead of icons. The icons would need attribution anyway, so better out than in. |
This reverts commit 443219a.
Icons don't work with themes :(
Just use boxes with glue to ensure the components expand as needed.
mjog
force-pushed
the
dockable-unit-detail
branch
from
eba0dc0 to
71563f8
Compare
|
@Windchild292 good to merge? |
Windchild292
approved these changes
Oct 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3110 with fixes for extra issues.