-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3498: Adding Clanner Tracking to MegaMek #3500
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3500 +/- ##
============================================
- Coverage 22.67% 22.67% -0.01%
- Complexity 4770 4771 +1
============================================
Files 2081 2081
Lines 243767 243777 +10
Branches 45591 45596 +5
============================================
+ Hits 55265 55267 +2
- Misses 187013 187021 +8
Partials 1489 1489
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Withdrawn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Withdrawn
Based on the conversations on Discord. Please adjust the wording of any player facing text to "Clan Pilot". While the preference is to not have any reference in the code to the term "Clanner" that can stand. |
How can I help here? |
Replaced by #5166 |
This handles the bug raised in #3498, namely that any melee attacks are based on the 'Mech's tech base and not the pilot / commander's status.