Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connections Rework: Logging Modernization #3908

Conversation

Windchild292
Copy link
Contributor

This modernizes the remaining connection logging issues and cleans up some more connection code.

@Windchild292 Windchild292 added Bug (RFE) Enhancement Requests for Enhancement, new features or implementations Refactoring labels Sep 20, 2022
@Windchild292 Windchild292 self-assigned this Sep 20, 2022
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 23.55% // Head: 23.55% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4b8137a) compared to base (7162859).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3908   +/-   ##
=========================================
  Coverage     23.55%   23.55%           
  Complexity     4810     4810           
=========================================
  Files          2212     2212           
  Lines        243100   243072   -28     
  Branches      45498    45494    -4     
=========================================
  Hits          57265    57265           
+ Misses       184376   184348   -28     
  Partials       1459     1459           
Impacted Files Coverage Δ
...mek/common/net/connections/AbstractConnection.java 0.00% <0.00%> (ø)
...k/common/net/connections/DataStreamConnection.java 0.00% <0.00%> (ø)
...gamek/common/net/marshalling/PacketMarshaller.java 0.00% <0.00%> (ø)
...ommon/net/marshalling/PacketMarshallerFactory.java 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Windchild292 Windchild292 merged commit 27e1e1f into MegaMek:master Sep 23, 2022
@Windchild292 Windchild292 deleted the dev_Windchild_ConnectionLoggingAndCleanup branch September 23, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Refactoring (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants