4021: Preventing Save Game Loading Player Name NPE #4023
Conversation
Windchild292
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1635,8 +1624,7 @@ | |||
| return nDamage; | |||
| } | |||
|
|
|||
| protected void handleIgnitionDamage(Vector<Report> vPhaseReport, | |||
| Building bldg, int hits) { | |||
| protected void handleIgnitionDamage(Vector<Report> vPhaseReport, Building bldg, int hits) { | |||
Check notice
Code scanning / CodeQL
Useless parameter
| @@ -1635,8 +1624,7 @@ | |||
| return nDamage; | |||
| } | |||
|
|
|||
| protected void handleIgnitionDamage(Vector<Report> vPhaseReport, | |||
| Building bldg, int hits) { | |||
| protected void handleIgnitionDamage(Vector<Report> vPhaseReport, Building bldg, int hits) { | |||
Check notice
Code scanning / CodeQL
Useless parameter
|
This pull request fixes 1 alert when merging 3a7e1a2 into 2ffa6f1 - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
|
This pull request fixes 1 alert when merging 68ef5e5 into c7e87ed - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
This fixes #4021. The first commit is cleanup while investigating the issue, the second commit is the actual fix.
I used manual XML parsing as we only need a few pieces to load in, and this prevents weird loading errors. It also now parses the version correctly if the file cannot load, which improves that handling too and prevents some other file load issues.