Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS conversion: disregard weapons lacking ammo #4087

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Jan 4, 2023

This PR makes AS damage conversion disregard ammo weapons that lack ammo.

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 23.02% // Head: 23.01% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0183019) compared to base (5fb1593).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4087      +/-   ##
============================================
- Coverage     23.02%   23.01%   -0.01%     
  Complexity     4816     4816              
============================================
  Files          2275     2275              
  Lines        249532   249537       +5     
  Branches      46286    46287       +1     
============================================
  Hits          57443    57443              
- Misses       190637   190642       +5     
  Partials       1452     1452              
Impacted Files Coverage Δ
...mmon/alphaStrike/conversion/ASDamageConverter.java 0.00% <0.00%> (ø)
...gamek/src/megamek/client/ratgenerator/Ruleset.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SJuliez SJuliez merged commit e7bb69e into MegaMek:master Jan 5, 2023
@SJuliez SJuliez deleted the AS_NoAmmo_Fix branch January 6, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants