Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attack tool tip update #4097

Merged
merged 5 commits into from
Jan 21, 2023
Merged

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Jan 11, 2023

attack tool tip update

  • show attacks that cross the current hex, instead of attacks at current point. this makes it easier for these to be displayed.
  • display attacks after the unit info, so that it does not hide the unit info when there are many attacks.
  • collapse multiple shots with the same weapon type into a single row.

image

image

image

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 23.01% // Head: 22.97% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (492a8d6) compared to base (9bad6b4).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4097      +/-   ##
============================================
- Coverage     23.01%   22.97%   -0.05%     
- Complexity     4815     4824       +9     
============================================
  Files          2275     2282       +7     
  Lines        249561   250115     +554     
  Branches      46293    46366      +73     
============================================
+ Hits          57445    57459      +14     
- Misses       190664   191204     +540     
  Partials       1452     1452              
Impacted Files Coverage Δ
...egamek/client/ui/swing/boardview/AttackSprite.java 0.00% <0.00%> (ø)
...c/megamek/client/ui/swing/boardview/BoardView.java 0.62% <0.00%> (-0.01%) ⬇️
megamek/src/megamek/common/Coords.java 48.21% <0.00%> (-0.29%) ⬇️
...ek/src/megamek/client/ui/swing/GUIPreferences.java 32.45% <0.00%> (-1.27%) ⬇️
megamek/src/megamek/common/Game.java 9.39% <0.00%> (-0.36%) ⬇️
megamek/src/megamek/common/Report.java 11.67% <0.00%> (-0.25%) ⬇️
megamek/src/megamek/common/HexTarget.java 7.84% <0.00%> (-0.16%) ⬇️
megamek/src/megamek/common/Mech.java 15.29% <0.00%> (-0.16%) ⬇️
megamek/src/megamek/common/Engine.java 36.08% <0.00%> (-0.06%) ⬇️
megamek/src/megamek/client/Client.java 5.09% <0.00%> (-0.03%) ⬇️
... and 83 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kuronekochomusuke kuronekochomusuke added (RFE) Enhancement Requests for Enhancement, new features or implementations GUI User Interface labels Jan 11, 2023
@kuronekochomusuke kuronekochomusuke marked this pull request as draft January 11, 2023 23:46
@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review January 15, 2023 16:53
@kuronekochomusuke
Copy link
Collaborator Author

this is ready for review

@HammerGS HammerGS merged commit 8a52edb into MegaMek:master Jan 21, 2023
HammerGS added a commit that referenced this pull request Jan 21, 2023
+ PR #4097: Attack Tool Tip update
@HammerGS
Copy link
Member

Thanks for these!

@kuronekochomusuke kuronekochomusuke deleted the attackToolTipUpdate branch March 3, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI User Interface (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants