BaseComponents: Adding Nag Dialog Setup #4112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windchild292
added
(RFE) Enhancement
NickAragua
reviewed
Jan 16, 2023
SJuliez
approved these changes
Jan 17, 2023
| //endregion Constructors | ||
|
|
||
| @Override | ||
| protected boolean checkNag() { |
There was a problem hiding this comment.
Does this need an override? It looks like it would already work in the super class.
There was a problem hiding this comment.
It does if we need to check other things, which is required in the MHQ implementations and likely for some MM implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the Nag Dialog setup to MM. There's two FIXME's for places where we should have access to frames but we do not right now.