Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

saveSettings updates #4123

Merged
merged 4 commits into from
Feb 4, 2023
Merged

saveSettings updates #4123

merged 4 commits into from
Feb 4, 2023

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Jan 19, 2023 •
edited
Loading

  • When the main window is closed, save the locations for the unit display dialog, mini map dialog, mini report dialog, and player list dialog.
  • for mini map dialog, save the height display mode. load this settings on startup.
  • reset mini map zoom to min zoom when resetting windows.

@kuronekochomusuke kuronekochomusuke added (RFE) Enhancement Requests for Enhancement, new features or implementations GUI User Interface labels Jan 19, 2023
Windchild292
Windchild292 reviewed Jan 29, 2023
View reviewed changes
Copy link
Contributor

@Windchild292 Windchild292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor accessibility fix

megamek/src/megamek/client/ui/swing/ClientGUI.java Outdated Show resolved Hide resolved
@kuronekochomusuke @Windchild292
Update megamek/src/megamek/client/ui/swing/ClientGUI.java
2044591 
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
@Windchild292 Windchild292 merged commit dbd312a into MegaMek:master Feb 4, 2023
@kuronekochomusuke kuronekochomusuke deleted the saveSettings branch March 3, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Windchild292 Windchild292 Windchild292 approved these changes

Assignees
No one assigned
Labels
GUI User Interface (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuronekochomusuke @Windchild292