Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

button tool tip for hot keys #4125

Merged
merged 9 commits into from
Jan 30, 2023
Merged

button tool tip for hot keys #4125

merged 9 commits into from
Jan 30, 2023

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Jan 20, 2023 •
edited
Loading

  • on the phase display buttons, update the tool tip to add the hot key bind description, when the button has a hot key.
  • correct issue with the done hot key not working in the report phases
  • reset defaultKeyBinds.xml to the defaults defined in KeyCommandBind
  • set quick save to Ctrl+Shift+S and quick load to Ctrl+Shift+L so it does not conflict with the LOS Setting hot key Ctrl+Alt+L

image

@kuronekochomusuke kuronekochomusuke added Bug (RFE) Enhancement Requests for Enhancement, new features or implementations GUI User Interface labels Jan 20, 2023
@kuronekochomusuke kuronekochomusuke marked this pull request as draft January 20, 2023 19:08
@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review January 22, 2023 19:26
SJuliez
SJuliez requested changes Jan 26, 2023
View reviewed changes
Copy link
Member

@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. I have a few requests and comments for this. A personal request would be to move the LOS settings to Ctrl-Alt-L and leave the quick-save and -load at Ctrl-Shift-S/L. I don't know, maybe people who play more and develop less see this differently.

megamek/src/megamek/client/ui/swing/DeployMinefieldDisplay.java Show resolved Hide resolved
megamek/src/megamek/client/ui/swing/FiringDisplay.java Show resolved Hide resolved
megamek/src/megamek/client/ui/swing/FiringDisplay.java Outdated Show resolved Hide resolved
@SJuliez SJuliez merged commit 0456564 into MegaMek:master Jan 30, 2023
@kuronekochomusuke kuronekochomusuke deleted the buttonToolTipHotKeys branch March 3, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SJuliez SJuliez SJuliez approved these changes

Assignees
No one assigned
Labels
Bug GUI User Interface (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuronekochomusuke @SJuliez