Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status bar update for players remaining #4128

Merged
merged 6 commits into from
Feb 7, 2023

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Jan 22, 2023

  • update status bar on reporting phases to show players who are not done.
  • update status bar on deployment, targeting, movement, firing, and physical phases to show players with next turns.
  • add a advanced setting to limit the number of players for these. set to 0 to not show any.

image

image

@kuronekochomusuke kuronekochomusuke marked this pull request as draft January 22, 2023 16:01
@kuronekochomusuke kuronekochomusuke added (RFE) Enhancement Requests for Enhancement, new features or implementations GUI User Interface labels Jan 22, 2023
@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review January 23, 2023 01:37
@SJuliez
Copy link
Member

SJuliez commented Jan 26, 2023

I'm not quite sure what to look for here. The [qwret, qasf] text? If so, may I suggest adding some helpful text because it doesn't look self-explanatory to me. Like: "Next turns: " or "Unfinished players: " or something. Also, if there are more turns than shown it might make sense to add a ", ..." at the end.

@HammerGS HammerGS merged commit 12a3fa6 into MegaMek:master Feb 7, 2023
HammerGS added a commit that referenced this pull request Feb 7, 2023
+ Issue #4128: Status bar update for players remaining
@kuronekochomusuke kuronekochomusuke deleted the statusBarUpdate branch March 3, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI User Interface (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants